Skip to content

oran-o2ims: add tls scanner - #82154

Open
rauhersu wants to merge 10 commits into
openshift:mainfrom
rauhersu:master.tls.scanner
Open

oran-o2ims: add tls scanner#82154
rauhersu wants to merge 10 commits into
openshift:mainfrom
rauhersu:master.tls.scanner

Conversation

@rauhersu

@rauhersu rauhersu commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds TLS scanner CI integration for openshift-kni/oran-o2ims.

The new install-bundle-tls-scan job:

  • Provisions an AWS cluster via the ipi-aws workflow.
  • Installs the operator using operator-sdk run bundle via the optional-operators-operator-sdk step-registry ref.
  • The operator auto-creates its default Inventory CR on startup, which triggers the reconciler to deploy all server pods.
  • Runs the tls-scanner-run step-registry ref to scan all TLS endpoints in the oran-o2ims namespace.

The job is configured as always_run: false and optional: true, so it does not run automatically on every PR and does not block merges. It can be triggered on demand with /test install-bundle-tls-scan.

Changes

  • ci-operator/config/openshift-kni/oran-o2ims/openshift-kni-oran-o2ims-main.yaml: Added tls-scanner-tool base image and the install-bundle-tls-scan test definition.
  • ci-operator/jobs/openshift-kni/oran-o2ims/openshift-kni-oran-o2ims-main-presubmits.yaml: Auto-generated by make jobs.

References

Summary by CodeRabbit

Adds optional TLS scanner CI integration for the openshift-kni/oran-o2ims component in the OpenShift CI infrastructure configuration (ci-operator/config/openshift-kni/oran-o2ims/openshift-kni-oran-o2ims-main.yaml).

  • Introduces a tls-scanner-tool base image entry used by the TLS scanning workflow.
  • Adds an optional Prow job install-bundle-tls-scan (always_run: false, optional: true, triggerable via /test install-bundle-tls-scan) that:
    • provisions an AWS cluster and installs the operator bundle into the oran-o2ims namespace (via operator-sdk run bundle);
    • waits for the auto-created inventory/default CR;
    • discovers Services annotated with service.beta.openshift.io/serving-cert-secret-name, derives pod label selectors from each Service’s spec.selector, and waits up to 5 minutes for matching pods to become Ready (logging pod status/events on timeout);
    • verifies the referenced TLS secrets exist in the oran-o2ims namespace;
    • enables TLS 1.3 adherence and runs an extra tls-13 workflow step before executing tls-scanner-run.
  • Updates the TLS scanner execution to support running probes in an existing target namespace to reduce NetworkPolicy false positives:
    • tls-scanner-run-ref.yaml adds SCANNER_NAMESPACE (empty by default); when set, the scanner uses the provided namespace rather than a dedicated tls-scanner namespace.
    • tls-scanner-run-commands.sh derives the scanner NAMESPACE from SCANNER_NAMESPACE and disables “owns namespace” behavior whenever SCANNER_NAMESPACE is explicitly set.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

The ORAN O2IMS CI configuration adds a TLS scanner image and optional validation job. The scanner now accepts an existing namespace through SCANNER_NAMESPACE, while the job checks Inventory services, pod readiness, and referenced TLS secrets.

Changes

ORAN O2IMS TLS validation

Layer / File(s) Summary
Configurable scanner namespace
ci-operator/step-registry/tls/scanner/run/tls-scanner-run-ref.yaml, ci-operator/step-registry/tls/scanner/run/tls-scanner-run-commands.sh
Adds SCANNER_NAMESPACE and uses it to select the scanner namespace and ownership behavior.
TLS workflow setup
ci-operator/config/openshift-kni/oran-o2ims/openshift-kni-oran-o2ims-main.yaml
Adds the tls-scanner-tool image, optional job inputs, and TLS 1.3 adherence settings.
Inventory service TLS validation
ci-operator/config/openshift-kni/oran-o2ims/openshift-kni-oran-o2ims-main.yaml
Waits for Inventory resources, validates annotated service pods and TLS secrets, and runs tls-13 before tls-scanner-run.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested labels: rehearsals-ack

Suggested reviewers: missxiaoguo, donpenney

Sequence Diagram(s)

sequenceDiagram
  participant CIJob
  participant OperatorBundle
  participant OpenShiftAPI
  CIJob->>OperatorBundle: Install operator-bundle in oran-o2ims
  CIJob->>OpenShiftAPI: Wait for Inventory and discover annotated services
  OpenShiftAPI-->>CIJob: Return pod selectors and TLS secret names
  CIJob->>OpenShiftAPI: Wait for selected pods to become Ready
  CIJob->>OpenShiftAPI: Verify referenced TLS secrets
  CIJob->>CIJob: Run tls-13 and tls-scanner-run
Loading
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding TLS scanner support for oran-o2ims.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo-style test titles were added or modified; the PR only changes CI YAML/job config, not test name definitions.
Test Structure And Quality ✅ Passed PR changes CI YAML and shell step-registry files only; no Ginkgo It/BeforeEach/Eventually test code was added or modified.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only changes CI/job config and shell-step wiring, so MicroShift test compatibility isn’t implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only changes CI config and a shell step, and neither introduces multi-node/HA assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed No topology-specific scheduling constraints were added; the new CI pod spec uses default scheduling and no nodeSelector/affinity/tolerations or replica logic.
Ote Binary Stdout Contract ✅ Passed PASS: The PR only changes CI config and shell-step scripts; no Go/TestMain/BeforeSuite/init code or binary stdout paths were modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added, and the touched job/step logic has no hardcoded IPv4 literals, IPv4-only parsing, or public-internet dependencies.
No-Weak-Crypto ✅ Passed Touched CI YAML/shell only add TLS scanner job/namespace handling; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto found.
Container-Privileges ✅ Passed HEAD only changes the oran-o2ims CI config; no added privileged/root/hostNetwork/hostPID/securityContext flags appear in the modified manifest.
No-Sensitive-Data-In-Logs ✅ Passed PASS: The only new lines are TLS adherence env vars and a tls-13 step; no passwords, tokens, PII, or hostnames are logged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2026
@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Hi @rauhersu. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
openshift-ci Bot requested review from Missxiaoguo and donpenney July 20, 2026 15:01
@rauhersu

Copy link
Copy Markdown
Contributor Author

@donpenney , may you run an ok-to-test ?

@donpenney

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2026
@rauhersu

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@rauhersu

Copy link
Copy Markdown
Contributor Author

/retest

@rauhersu

Copy link
Copy Markdown
Contributor Author

/test ci-operator-config
/test generated-config

@rauhersu

Copy link
Copy Markdown
Contributor Author

/test generated-config

@rauhersu

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 21, 2026
@rauhersu

rauhersu commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

The new TLS scanner - install-bundle-tls-scan job - was successfully executed and the logs can be examined under the Prow job 'artifacts' section after clicking on the job in this github conversation.

Example for this execution:

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/82154/rehearse-82154-pull-ci-openshift-kni-oran-o2ims-main-install-bundle-tls-scan/2079529959986040832/artifacts/install-bundle-tls-scan/tls-scanner-run/artifacts/tls-scanner/

After this PR merges, then on any PR to openshift-kni/oran-o2ims, someone can trigger it with /test install-bundle-tls-scan.

@Missxiaoguo @donpenney , I would need a lgtm+approve if you agree with these changes.

@RomanBednar

Copy link
Copy Markdown
Contributor

Since one of my PRs is referenced here - if you are looking for TLS Adherence test this setup won't do. If you're looking for plain compliance check it's fine.

I later found out that I missed it in the AWS tls scan job referenced here and had to amend it to get the scanner check TLS adherence which is what I was looking for.

In other words tls-scanner-run runs the tls scanner and checks if tls endpoints meet some criteria, but if tls-13 job precedes it, it will actually check if the tls parameters in api are respected by pods in the given namespace. It's a very strange design so just leaving a comment here - use as needed :)

@rauhersu

rauhersu commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Need to assess the new @RomanBednar comment. Thanks, Roman !

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2026
@rauhersu
rauhersu force-pushed the master.tls.scanner branch from a6c6c37 to 3ce5266 Compare July 24, 2026 13:42
@rauhersu rauhersu changed the title add tls scanner for oran-o2ims oran-o2ims: add tls scanner Jul 24, 2026
@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 24, 2026
@rauhersu

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rauhersu

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@rauhersu

Copy link
Copy Markdown
Contributor Author

/retest

@rauhersu

Copy link
Copy Markdown
Contributor Author

/retest

@rauhersu
rauhersu force-pushed the master.tls.scanner branch from 3ce5266 to 0d5f3d0 Compare July 27, 2026 08:44
@rauhersu

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rauhersu

rauhersu commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

2 similar comments
@rauhersu

rauhersu commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@rauhersu

rauhersu commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

1 similar comment
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rauhersu
rauhersu force-pushed the master.tls.scanner branch from e42884d to 9f666e5 Compare August 6, 2026 16:42
@rauhersu

rauhersu commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rauhersu and others added 9 commits August 7, 2026 19:12
Signed-off-by: Raul Hernandez <rauherna@redhat.com>
- Add a wait-for-server-pods inline step to the install-bundle-tls-scan
  test that dynamically discovers TLS-serving services via the
  service.beta.openshift.io/serving-cert-secret-name annotation, waits
  for their backing pods to become Ready, and verifies that service-ca
  TLS secrets exist before the tls-scanner runs. This avoids hardcoding
  server names.

- Move operator.substitutions under the bundle item where it belongs,
  making the pullspec override explicitly scoped to the operator-bundle.
…space

  The scanner always runs in a dedicated tls-scanner namespace. When
  scanning pods with NetworkPolicies restricting ingress to same-namespace
  traffic (e.g. oran-o2ims servers), the TLS handshake probes are blocked,
  producing false NO_TLS results.

  Add a SCANNER_NAMESPACE env var that deploys the scanner pod into an
  existing namespace instead, reusing the OWNS_NAMESPACE=false pattern
  already used by the HyperShift management-cluster path.

  Set SCANNER_NAMESPACE=oran-o2ims in the install-bundle-tls-scan test so
  the scanner satisfies the oran-o2ims NetworkPolicy rules.
When the scanner pod fails (e.g. TLS compliance violations), the script
exits before reaching the trap unregistration at the end of
run_tls_scan. The EXIT trap fires the cleanup function, but bash
unwinds the function call stack before running the trap handler.
Since NAMESPACE and OWNS_NAMESPACE were declared local to
run_tls_scan, they no longer exist in the trap handler's scope,
causing a fatal "unbound variable" error under set -o nounset.

Fix by removing the local qualifier from both variables. They are
safe as globals: the non-HyperShift path calls the function once,
and the HyperShift path runs each invocation in a subshell that
isolates variable state.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Raúl Hernández <rauherna@redhat.com>
Upstream PR openshift#82522 fixed the cleanup trap crash by snapshotting locals
into _CLEANUP_* globals. Restore NAMESPACE and OWNS_NAMESPACE to local
(matching upstream) while keeping the SCANNER_NAMESPACE logic from our
earlier commits.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Raúl Hernández <rauherna@redhat.com>
Add the install-bundle-tls-scan test with TLS Adherence
(StrictAllComponents) and tls-scanner to the release-4.22 config,
matching the main branch configuration.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Raúl Hernández <rauherna@redhat.com>
Add install-bundle-tls-scan-periodic to both main (Fridays 03:00 UTC)
and release-4.22 (Mondays 03:00 UTC) configurations. The periodic jobs
are identical to the on-demand variants but run on a cron schedule.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Raúl Hernández <rauherna@redhat.com>
@rauhersu
rauhersu force-pushed the master.tls.scanner branch from 94b327b to e2190d8 Compare August 7, 2026 17:25
@rauhersu

rauhersu commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rauhersu

rauhersu commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-oran-o2ims-release-4.22-install-bundle-tls-scan-periodic

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rauhersu

rauhersu commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-cert-manager-operator-master-tls-scanner

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

@rauhersu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-lvm-operator-release-4.22-nightly-e2e-aws-mno-qe-integration-tests e42884d link unknown /pj-rehearse periodic-ci-openshift-lvm-operator-release-4.22-nightly-e2e-aws-mno-qe-integration-tests
ci/rehearse/openshift/insights-runtime-extractor/main/tls-scanner bf2e28c link unknown /pj-rehearse pull-ci-openshift-insights-runtime-extractor-main-tls-scanner
ci/rehearse/openshift/oadp-operator/oadp-dev/4.22-tls-pqc-readiness e42884d link unknown /pj-rehearse pull-ci-openshift-oadp-operator-oadp-dev-4.22-tls-pqc-readiness
ci/rehearse/periodic-ci-openshift-lvm-operator-main-nightly-e2e-aws-mno-qe-integration-tests 9f666e5 link unknown /pj-rehearse periodic-ci-openshift-lvm-operator-main-nightly-e2e-aws-mno-qe-integration-tests
ci/rehearse/openshift/cert-manager-operator/master/tls-scanner e2190d8 link unknown /pj-rehearse pull-ci-openshift-cert-manager-operator-master-tls-scanner

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Set PQC_CHECK=true across all TLS scan pipelines (on-demand and
periodic) for main and release-4.22. This enables post-quantum
cryptography readiness checks (TLS 1.3 + mlkem/mlkem25519 support).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Raúl Hernández <rauherna@redhat.com>
@rauhersu

rauhersu commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rauhersu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rauhersu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-autoscaler-operator-main-e2e-aws openshift/cluster-autoscaler-operator presubmit Registry content changed
pull-ci-openshift-cluster-autoscaler-operator-release-5.1-e2e-aws openshift/cluster-autoscaler-operator presubmit Registry content changed
pull-ci-openshift-cluster-autoscaler-operator-release-5.0-e2e-aws openshift/cluster-autoscaler-operator presubmit Registry content changed
pull-ci-openshift-cluster-autoscaler-operator-release-4.23-e2e-aws openshift/cluster-autoscaler-operator presubmit Registry content changed
pull-ci-openshift-insights-runtime-extractor-main-tls-scanner openshift/insights-runtime-extractor presubmit Registry content changed
pull-ci-openshift-insights-runtime-extractor-release-5.1-tls-scanner openshift/insights-runtime-extractor presubmit Registry content changed
pull-ci-openshift-insights-runtime-extractor-release-5.0-tls-scanner openshift/insights-runtime-extractor presubmit Registry content changed
pull-ci-openshift-insights-runtime-extractor-release-4.23-tls-scanner openshift/insights-runtime-extractor presubmit Registry content changed
pull-ci-openshift-insights-runtime-extractor-release-4.22-tls-scanner openshift/insights-runtime-extractor presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-main-tls-scanner-default-profile openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-main-tls-scanner-modern-profile openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-release-5.1-tls-scanner-default-profile openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-release-5.1-tls-scanner-modern-profile openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-release-5.0-tls-scanner-default-profile openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-release-5.0-tls-scanner-modern-profile openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-release-4.23-tls-scanner-default-profile openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-release-4.23-tls-scanner-modern-profile openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-release-4.22-tls-scanner openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-secrets-store-csi-driver-operator-main-tls-scanner openshift/secrets-store-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-secrets-store-csi-driver-operator-release-5.1-tls-scanner openshift/secrets-store-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-secrets-store-csi-driver-operator-release-5.0-tls-scanner openshift/secrets-store-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-secrets-store-csi-driver-operator-release-4.23-tls-scanner openshift/secrets-store-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-cincinnati-operator-master-install-bundle-tls-scan openshift/cincinnati-operator presubmit Registry content changed
pull-ci-openshift-insights-operator-master-tls-scanner openshift/insights-operator presubmit Registry content changed
pull-ci-openshift-insights-operator-release-5.1-tls-scanner openshift/insights-operator presubmit Registry content changed

A total of 135 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants